Validate checkedExceptionClasses config #3987
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janedbal
commented
May 12, 2025
| { | ||
| foreach ($this->checkedExceptionClasses as $checkedExceptionClass) { | ||
| if (!$this->reflectionProvider->hasClass($checkedExceptionClass)) { | ||
| throw new ShouldNotHappenException('Class ' . $checkedExceptionClass . ' used in \'checkedExceptionClasses\' does not exist.'); |
There was a problem hiding this comment.
Not sure if this is the preferred way of config validation.
| if (!$this->reflectionProvider->hasClass($uncheckedExceptionClass)) { | ||
| throw new ShouldNotHappenException('Class ' . $uncheckedExceptionClass . ' used in \'uncheckedExceptionClasses\' does not exist.'); | ||
| } | ||
| } |
There was a problem hiding this comment.
Do you want that behind featureFlag / bleedingEdge? I think this will be pretty rare.
ondrejmirtes
requested changes
Jul 17, 2025
- Moved validation from DefaultExceptionTypeResolver constructor to ContainerFactory::validateParameters() - Added bleeding edge feature flag protection to avoid BC break - Use InvalidConfigurationException for proper error handling - Note: The required placement in validateParameters() complicates the code as we cannot use BleedingEdgeToggle::isBleedingEdge() since it's not initialized yet, requiring manual parameter checking 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
ondrejmirtes
requested changes
Aug 30, 2025
| } | ||
|
|
||
| if (array_key_exists('featureToggles', $parameters) && is_array($parameters['featureToggles']) && (bool) $parameters['featureToggles']['bleedingEdge']) { | ||
| $this->validateExceptionClasses($parameters); |
There was a problem hiding this comment.
You can put these conditions right next to:
$container = $configurator->createContainer()->getByType(Container::class);
$this->validateParameters($container->getParameters(), $projectConfig['parametersSchema']);
And pass ReflectionProvider properly from $container instead of obtaining it statically.
There was a problem hiding this comment.
Meaning do not call validateExceptionClasses from inside validateParameters, but instead from create.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.