Bleeding edge - improve comparison against BcMath\Number #3995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlndh
commented
May 16, 2025
Comment on lines
+64
to
+69
| $scope->getType($node->left), | ||
| $scope->getType($node->right), |
There was a problem hiding this comment.
This might cause some issues below level 7, but I'm not sure how to improve it. The operator type specifying extensions don't support union well anyway.
|
Please fix the conflicts. Meanwhile the way how rules are registered have changed. Instead of entries in config.neon, parameters are now autowired with an attribute like this: |
schlndh
force-pushed
the
fix-bcMathComparisonOperators
branch
from
fd98762 to
6e7aab4
Compare
|
@ondrejmirtes Done. Thank you for the tip about AutowiredParameter (one more thing that took me a few minutes was that it's also necessary to run |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: phpstan/phpstan#13001
Behavior test: https://3v4l.org/K7THf