Improve support switch on ::class

[VincentLanglet]

Closes phpstan/phpstan#13069

[VincentLanglet]

The findTypeExpressionFromBinaryOperation is used two times:

• Inside resolveIdentical
• Inside resolveEqual

Inside resolveIdentical the ClassConstFetch scenario is not needed. But removing the check does not have impact since then the following code

$expressions = $this->findTypeExpressionsFromBinaryOperation($scope, $expr);
		if ($expressions !== null) {
			$exprNode = $expressions[0];
			$constantType = $expressions[1];

			$unwrappedExprNode = $exprNode;
			if ($exprNode instanceof AlwaysRememberedExpr) {
				$unwrappedExprNode = $exprNode->getExpr();
			}

			$specifiedType = $this->specifyTypesForConstantBinaryExpression($unwrappedExprNode, $constantType, $context, $scope, $expr);

gives a NULL $specifiedType.

Inside resolveEqual the ClassConstFetch is needed for an easy check

$context->true()
				&& $exprNode instanceof ClassConstFetch
				&& $exprNode->name instanceof Node\Identifier
				&& strtolower($exprNode->name->toString()) === 'class'
				&& $constantType->isString()->yes()

without checking both the right side and the left side.

Not sure if you're ok with such change.
I could had a boolean parameter to remove or not the ClassConstFetch check but I'm not sure it's worth it.

[ondrejmirtes]

Thank you.