Skip to content

Conversation

staabm
Copy link
Contributor

@staabm staabm commented May 25, 2025

No description provided.

@staabm
Copy link
Contributor Author

staabm commented May 25, 2025

Pretty interessting that most *ClassReflectionExtension in the config.neon don't have any tags added.
seems it might make sense to drop these extension type from AutowiredAttributeServicesExtension.

see

  • 0cdc824
  • 3f30928
    in which I reverted back to the previous style to fix a end-2-end test

@staabm staabm marked this pull request as ready for review May 25, 2025 20:06
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@ondrejmirtes
Copy link
Member

Yeah, if there's a service of a class implementing an interface, but the service doesn't have a tag, it currently cannot use the attribute.

This is about extensions manually retrieved in LazyClassReflectionExtensionRegistryProvider to ensure a certain ordering.

@ondrejmirtes ondrejmirtes merged commit 6194cf2 into phpstan:2.1.x May 25, 2025
420 of 421 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@staabm staabm deleted the more2 branch May 28, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants