Skip to content

Fix DOMElement::$attributes stub #4029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025
Merged

Fix DOMElement::$attributes stub #4029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c6761c
Fix 13076
VincentLanglet May 27, 2025
ed54aff
Try
VincentLanglet Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion stubs/dom.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class DOMNode
public $attributes;

/**
* @phpstan-assert-if-true !null $this->attributes
* @phpstan-assert-if-true =DOMNamedNodeMap $this->attributes
* @return bool
*/
public function hasAttributes() {}
Expand All @@ -46,6 +46,9 @@ class DOMNode
class DOMElement extends DOMNode
{

/** @var DOMNamedNodeMap */
public $attributes;

/** @var DOMDocument */
public $ownerDocument;

Expand Down
26 changes: 26 additions & 0 deletions tests/PHPStan/Analyser/nsrt/bug-13076.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<?php declare(strict_types = 1);

namespace Bug13076;

use function PHPStan\Testing\assertType;

class Foo
{
public function test(\DOMNode $node): void
{
if ($node->hasAttributes()) {
assertType('DOMNamedNodeMap', $node->attributes);
} else {
assertType('DOMNamedNodeMap|null', $node->attributes);
}
}

public function testElement(\DOMElement $node): void
{
if ($node->hasAttributes()) {
assertType('DOMNamedNodeMap', $node->attributes);
} else {
assertType('DOMNamedNodeMap', $node->attributes);
}
}
}
Loading