TableErrorFormatter: Use two spaces instead of one #4031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 59a003a.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts commit 59a003a which was part of #3821.
Why?
Before merging #3821, I was asked to replace the seemingly incorrect double spaces with a single space.
After upgrading to the latest version of PHPStan today, I noticed that the double spaces from before were used on purpose, because an emoji character may exceed the width of a single monospace character. Depending on the terminal engine in use, the following characters are either overlapped or shifted to the right.
Using two spaces instead of one makes sure that the output looks good in all terminals (see "After" examples).
Example 1: PhpStorm
The emoji overlaps the next character.
Example 2: Windows Terminal
The emoji pushes all following characters to the right.