Skip to content

Conversation

ondrejmirtes
Copy link
Member

No description provided.

@staabm
Copy link
Contributor

staabm commented Jun 3, 2025

root cause for the PHP 7.4 only CI errors is, that the transformed code contains lines like

		#[AutowiredParameter] 		bool $checkClassCaseSensitivity,
		#[AutowiredParameter]		bool $checkThisOnly

while for PHP7.x compat the attributes need to stay on there own line:

		#[AutowiredParameter]
 		bool $checkClassCaseSensitivity,
		#[AutowiredParameter]
		bool $checkThisOnly

@ondrejmirtes
Copy link
Member Author

I know. nikic/PHP-Parser 5.5.0 even addresses this, I think I'm setting it up correctly but it doesn't work yet.

@staabm
Copy link
Contributor

staabm commented Jun 3, 2025

narrowed it further down. it only happens in __construct methods. if renaming the method to abc it works like expected

@ondrejmirtes
Copy link
Member Author

You don't need to look into it, I already solved it.

@ondrejmirtes ondrejmirtes force-pushed the autowired-parameter branch from c3fcc8d to d8556bf Compare June 3, 2025 14:02
@ondrejmirtes
Copy link
Member Author

Blocked on #2955 + humbug/php-scoper#1122

@ondrejmirtes ondrejmirtes force-pushed the autowired-parameter branch 2 times, most recently from 0572f9e to 1d1c57c Compare June 3, 2025 19:26
@ondrejmirtes ondrejmirtes force-pushed the autowired-parameter branch from 1d1c57c to 40ff6ef Compare June 4, 2025 19:07
@ondrejmirtes ondrejmirtes merged commit cb7ee52 into 2.1.x Jun 4, 2025
421 of 423 checks passed
@ondrejmirtes ondrejmirtes deleted the autowired-parameter branch June 4, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants