Skip to content

Conversation

RobiNN1
Copy link

@RobiNN1 RobiNN1 commented Jun 5, 2025

@ondrejmirtes
Copy link
Member

Hey, this is too many changes and it's impossible to review. What actual bugs are you experiencing?

We could also remove these entries altogether and just rely on phpstorm-stubs. "Reflection golden test" workflow will tell us what actual data would change.

@RobiNN1
Copy link
Author

RobiNN1 commented Jun 5, 2025

I added changes from from JetBrains/phpstorm-stubs@348c656

The current signatures are outdated, and more than 50 functions are missing. It was outdated in phpstorm stubs and here too

@RobiNN1
Copy link
Author

RobiNN1 commented Jun 5, 2025

I'm working on new PR and tried to keep the original parameter names, but the difference is still huge. The old signatures of many functions don't even have defined return types.

@ondrejmirtes
Copy link
Member

Here's a PR where I'm removing all the signatures: #4055

Here are the changes in reflection data: https://github.com/phpstan/phpstan-src/actions/runs/15553088664/job/43787529381

You could go through them and maybe improve the stubs in phpstorm-stubs based on that so that we could remove the signatures on PHPStan's side. Thank you.

@RobiNN1 RobiNN1 closed this Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants