Skip to content

Avoid false positif in_array always true #4073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2025
Merged

Avoid false positif in_array always true #4073

merged 3 commits into from
Jul 17, 2025

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Jun 26, 2025 •
edited
Loading

@VincentLanglet VincentLanglet marked this pull request as ready for review June 26, 2025 10:46
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@VincentLanglet
Copy link
Contributor Author

I don't think it's enough to close #4073 @ondrejmirtes but at least I hope it will help.

Seems like this fix:

  • Avoid false positive
  • Do not produce any tested regression (and even if there is, I think it's better for PHPStan to have false-negative rather than false-positive)

@ondrejmirtes ondrejmirtes merged commit 7538546 into phpstan:2.1.x Jul 17, 2025
418 of 420 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@VincentLanglet @phpstan-bot @ondrejmirtes