Resolve ObjectType::getArraySize() with count() only if defined

[vojtech-dobes]

Fix for phpstan/phpstan#13187

[ondrejmirtes]

Thank you!

[uuf6429]

Based on the example in the test, I don't quite get how this change makes sense.

interface Baz {}

function doBaz(Baz $baz): void {
     assertType('int<0, max>', count($baz));   // should be *ERROR* IMO
}

Even if $baz was an instance that implemented \Countable (and Baz), PHPStan should still complain at that point that it might not be countable. In this case, since there are no classes or interfaces implementing/extending Baz, it's also definitely not countable.

Am I missing something?

[ondrejmirtes]

@uuf6429 PHPStan is still going to report Parameter #1 $value of function count expects array|Countable, Baz given.: https://phpstan.org/r/b9e378ae-02fc-4788-910e-51a081a8fe4c

No reason to make the return type ErrorType.

[uuf6429]

Hmm, I was confused on the basis of the test. If I understand it well such warnings are collected separately and in that case ignored?

I must admit that I tried the playground too, but assumed the change might not have been released (although I suppose that's what "bleeding edge" is for).

Anyway, all good, thanks for checking.