-
Notifications
You must be signed in to change notification settings - Fork 525
Correctly retrieve hasSideEffects metadata for inherited methods #4079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d05e42c
Added Enum stubs to make method purity precise
zonuexe e0afa6c
Add PHPDoc type
zonuexe f54f785
Revert "Add PHPDoc type"
zonuexe 6ef434c
Revert "Added Enum stubs to make method purity precise"
zonuexe 9ae7517
Removed unnecessary workaround for BackedEnum
zonuexe 113c0cf
Add test
zonuexe 8732aa9
Checking for side effects from ancestor metadata
zonuexe 7b67a9b
Fix variable name
zonuexe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
<?php | ||
|
||
interface BackedEnum extends UnitEnum | ||
{ | ||
/** | ||
* @return static | ||
* @pure | ||
*/ | ||
public static function from(int|string $value): static; | ||
|
||
/** | ||
* @return ?static | ||
* @pure | ||
*/ | ||
public static function tryFrom(int|string $value): ?static; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<?php | ||
|
||
interface UnitEnum | ||
{ | ||
/** | ||
* @return list<static> | ||
* @pure | ||
*/ | ||
public static function cases(): array; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
<?php // lint >= 8.1 | ||
|
||
namespace PHPStan\Rules\Pure\data\Bug13201; | ||
|
||
enum Foo: string | ||
{ | ||
|
||
case Bar = 'bar'; | ||
case Unknown = 'unknown'; | ||
|
||
} | ||
|
||
/** | ||
* @pure | ||
*/ | ||
function createWithFallback(string $type): Foo | ||
{ | ||
return Foo::tryFrom($type) ?? Foo::Unknown; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While debugging with @nsfisis, he pointed out that this DocBlock causes the return value to be a
mixed
type.Although it is redundant, in the scope of this PR it makes sense to duplicate the type declarations in the PHPDoc.