Add support for multiple identifiers in ignoreErrors configuration #4080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update parametersSchema.neon to support 'identifiers' array field - Modify IgnoredErrorHelper to expand identifiers array into separate rules - Update IgnoredError::stringifyPattern() to display multiple identifiers - Add comprehensive tests for identifiers array functionality - Update IgnoreErrorsTest to reflect new configuration entries Resolves #13015 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Jul 17, 2025
- Replace assertEmpty() with assertNoErrors() for clearer test intent - Replace assert() with assertInstanceOf() for proper PHPUnit assertions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Thank you! Please also send update to https://phpstan.org/user-guide/ignoring-errors with a brief mention of |
There was a problem hiding this comment.
There is some inconsistency
If both identifier and identifiers are used:
- identifier is read in stringifyPattern
- identifiers is read in IgnoredErrorHelper
Also maybe it shouldn't be allowed to have both identifier and identifiers ?
Or the behavior should be to merge both ?
|
I don't want to allow both in the same entry. stringifyPattern should be fixed I think? |
I agree, I opened #4143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves phpstan/phpstan#13015
🤖 Generated with Claude Code