Skip to content

Trivial optimization #4083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2025
Merged

Trivial optimization #4083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b114ef
Use str_starts_with() instead of strpos()
zonuexe Jul 6, 2025
f680175
Avoid duplicating the same strpos() function call
zonuexe Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Rules/ClassForbiddenNameCheck.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,12 @@ public function checkClassNames(array $pairs): array
$projectName = $project;
$withoutPrefixClassName = substr($className, strlen($prefix));

if (strpos($withoutPrefixClassName, '\\') === false) {
$pos = strpos($withoutPrefixClassName, '\\');
if ($pos === false) {
continue;
}

$withoutPrefixClassName = substr($withoutPrefixClassName, strpos($withoutPrefixClassName, '\\'));
$withoutPrefixClassName = substr($withoutPrefixClassName, $pos);
}

if ($projectName === null) {
Expand Down
4 changes: 2 additions & 2 deletions src/Testing/TypeInferenceTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
use function is_string;
use function preg_match;
use function sprintf;
use function str_starts_with;
use function stripos;
use function strpos;
use function strtolower;
use function version_compare;
use const PHP_VERSION;
Expand Down Expand Up @@ -424,7 +424,7 @@ private static function isFileLintSkipped(string $file): bool
}

// ignore shebang line
if (strpos($firstLine, '#!') === 0) {
if (str_starts_with($firstLine, '#!')) {
$firstLine = fgets($f);
if ($firstLine === false) {
return false;
Expand Down
Loading