Skip to content

ObjectType: fix hasConstant behaviour #4089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2025
Merged

ObjectType: fix hasConstant behaviour #4089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/Type/ObjectType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,14 +869,20 @@ public function canAccessConstants(): TrinaryLogic

public function hasConstant(string $constantName): TrinaryLogic
{
$class = $this->getClassReflection();
if ($class === null) {
$classReflection = $this->getClassReflection();
if ($classReflection === null) {
return TrinaryLogic::createMaybe();
}

if ($classReflection->hasConstant($constantName)) {
return TrinaryLogic::createYes();
}

if ($classReflection->isFinal()) {
return TrinaryLogic::createNo();
}

return TrinaryLogic::createFromBoolean(
$class->hasConstant($constantName),
);
return TrinaryLogic::createMaybe();
}

public function getConstant(string $constantName): ClassConstantReflection
Expand Down
35 changes: 35 additions & 0 deletions tests/PHPStan/Type/ObjectTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,41 @@ public function testAccepts(
);
}

public static function dataHasConstant(): Iterator
{
yield [
new ObjectType(DateTimeImmutable::class),
'ATOM',
TrinaryLogic::createYes(),
];
yield [
new ObjectType(DateTimeImmutable::class),
'CUSTOM',
TrinaryLogic::createMaybe(),
];
yield [
new ObjectType(Closure::class), // is final
'CUSTOM',
TrinaryLogic::createNo(),
];
yield [
new ObjectType('SomeNonExistingClass'),
'CUSTOM',
TrinaryLogic::createMaybe(),
];
}

#[DataProvider('dataHasConstant')]
public function testHasConstant(ObjectType $type, string $constantName, TrinaryLogic $expectedResult): void
{
$actualResult = $type->hasConstant($constantName);
$this->assertSame(
$expectedResult->describe(),
$actualResult->describe(),
sprintf('%s -> hasConstant("%s")', $type->describe(VerbosityLevel::precise()), $constantName),
);
}

public function testGetClassReflectionOfGenericClass(): void
{
$objectType = new ObjectType(Traversable::class);
Expand Down
Loading