Skip to content

Add non regression test for 13043 #4109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025

Conversation

VincentLanglet
Copy link
Contributor

Closes phpstan/phpstan#13043

This was resolved when improving the array_map return type.

Also, I tried doing some triage and I think some issues which might be closed:

Dunno if it helps you (?)

@ondrejmirtes
Copy link
Member

I'm thankful for the triage you did but please do not mention it in a non-related PR, instead post a comment in each issue.

@ondrejmirtes ondrejmirtes merged commit a8a68f1 into phpstan:2.1.x Jul 21, 2025
254 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@VincentLanglet
Copy link
Contributor Author

I'm thankful for the triage you did but please do not mention it in a non-related PR, instead post a comment in each issue.

Ok.

Do I need to ping you in each issue ? Or just commenting is enough for you to get a notification ?

Also I assume I don't have to ping you for the ones already listed here (?)

@ondrejmirtes
Copy link
Member

I see all comments, even if they don't mention me. Yes, please say in each one of them that they can be closed, because when I close them the author will know why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

str_replace on array search & replace loses non-empty-string type of subject
2 participants