Fix lowercase string usage in template #4122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#12739
Seems like the issue is related to the fact that
ScalarType<string>
andScalarType<lowercase-string>
had the same cacheKey or something like that.AccessoryLowercaseStringType
andAccessoryUppercaseStringType
was lost forlevel::cache
because the check was onlyisPrecise
.So I added
$level->isCache()
and updated every$level->isPrecise()
checks (with tests).But I dunno if it's not better to do something like
(And eventually rename the method to
isAtLeastPrecise
? Your call @ondrejmirtes.