Handle empty array case via ConstantArrayType::spliceArray()
#4140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically acts as recursion guard because a bit later the following piece of code
would degrade the empty constant array to the same empty constant array, calling the same method again, which then leads to infinite recursion.
We have that exact same code for
sliceArray()
as well btw.Closes phpstan/phpstan#13279
Was introduced in #3952