Fix PropertyExistsTypeSpecifyingExtension for union types

src/Type/Php/PropertyExistsTypeSpecifyingExtension.php

@@ -55,8 +55,9 @@
 		TypeSpecifierContext $context,
 	): SpecifiedTypes
 	{
-		$propertyNameType = $scope->getType($node->getArgs()[1]->value);
-		if (!$propertyNameType instanceof ConstantStringType) {
+		$propertyNameTypes = $scope->getType($node->getArgs()[1]->value)->getConstantStrings();
+
+		if ($propertyNameTypes === []) {
 			return $this->typeSpecifier->create(
 				new FuncCall(new FullyQualified('property_exists'), $node->getRawArgs()),
 				new ConstantBooleanType(true),
@@ -65,34 +66,45 @@
 			);
 		}
 
-		if ($propertyNameType->getValue() === '') {
-			return new SpecifiedTypes([], []);
+		$hasPropertyTypes = [];
+		foreach ($propertyNameTypes as $propertyNameType) {
+			if($propertyNameType->getValue() === '') {
+				return new SpecifiedTypes([], []);
+			}
+
+			$hasPropertyTypes[] = new HasPropertyType($propertyNameType->getValue());
 		}
 
 		$objectType = $scope->getType($node->getArgs()[0]->value);
 		if ($objectType instanceof ConstantStringType) {
 			return new SpecifiedTypes([], []);
 		} elseif ($objectType->isObject()->yes()) {
-			$propertyNode = new PropertyFetch(
-				$node->getArgs()[0]->value,
-				new Identifier($propertyNameType->getValue()),
-			);
+			$propertyNodes = [];
+
+			foreach($propertyNameTypes as $propertyNameType) {
+				$propertyNodes[] = new PropertyFetch(
+					$node->getArgs()[0]->value,
+					new Identifier($propertyNameType->getValue()),
+				);
+			}
 		} else {
 			return new SpecifiedTypes([], []);
 		}
 
-		$propertyReflection = $this->propertyReflectionFinder->findPropertyReflectionFromNode($propertyNode, $scope);
-		if ($propertyReflection !== null) {
-			if (!$propertyReflection->isNative()) {
-				return new SpecifiedTypes([], []);
+		foreach($propertyNodes as $propertyNode) {
+			$propertyReflection = $this->propertyReflectionFinder->findPropertyReflectionFromNode($propertyNode, $scope);
+			if ($propertyReflection !== null) {
+				if (!$propertyReflection->isNative()) {
+					return new SpecifiedTypes([], []);
+				}
 			}
 		}
 
 		return $this->typeSpecifier->create(
 			$node->getArgs()[0]->value,
 			new IntersectionType([
 				new ObjectWithoutClassType(),
-				new HasPropertyType($propertyNameType->getValue()),
+				...$hasPropertyTypes,
 			]),
 			$context,
 			$scope,

tests/PHPStan/Analyser/nsrt/bug-13304.php

@@ -0,0 +1,25 @@
+<?php
+
+namespace Bug13304;
+
+use function PHPStan\Testing\assertType;
+
+function foo(object $foo): void
+{
+	foreach (['qux', 'quux'] as $property) {
+		if (!property_exists($foo, $property)) {
+			throw new \Exception;
+		}
+
+		assertType("object&hasProperty(quux)&hasProperty(qux)", $foo);
+	}
+}
+
+function bar(object $bar): void
+{
+	if (!property_exists($bar, '')) {
+		throw new \Exception;
+	}
+
+	assertType("object", $bar);
+}