Improve implode signature #4159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Jul 26, 2025
VincentLanglet
force-pushed
the
fix/5760
branch
2 times, most recently
from
8e14c10 to
4e8384f
Compare
staabm
reviewed
Jul 26, 2025
Collaborator
|
This pull request has been marked as ready for review. |
VincentLanglet
force-pushed
the
fix/5760
branch
from
f4a36cb to
1c8068f
Compare
ondrejmirtes
requested changes
Sep 2, 2025
Member
ondrejmirtes
left a comment
ondrejmirtes
left a comment
There was a problem hiding this comment.
Please fix the conflict. It'd probably be the best if you manually check out ParametersAcceptorSelector currently on top of 2.1.x and try to apply your changes in it manually. Because the Git conflict might get hairy.
VincentLanglet
force-pushed
the
fix/5760
branch
from
1c8068f to
188b089
Compare
Member
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#5760
Closes phpstan/phpstan#12079