Skip to content

Detect more possibly-impossible offset #4164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 7, 2025
Merged

Detect more possibly-impossible offset #4164

merged 5 commits into from
Sep 7, 2025

Conversation

@VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Jul 26, 2025

@ondrejmirtes
Copy link
Member

ondrejmirtes commented Jul 26, 2025

I feel like the error could always be reported on level 7+.

The difference is that the reportPossiblyUndefined... option is for offsets like string, but in this case this is about a union and one of the union parts never exists on the constant array so it'd be a good fit for L7+ without any extra option.

@VincentLanglet VincentLanglet changed the title Add non regression test Detect more possibly-impossible offset Jul 26, 2025
@VincentLanglet VincentLanglet marked this pull request as draft July 26, 2025 15:47
@VincentLanglet VincentLanglet force-pushed the test/1061 branch 10 times, most recently from c290ea1 to 2417411 Compare August 1, 2025 11:28
@VincentLanglet VincentLanglet marked this pull request as ready for review August 1, 2025 11:43
@phpstan-bot
Copy link
Collaborator

phpstan-bot commented Aug 1, 2025

This pull request has been marked as ready for review.

ondrejmirtes
ondrejmirtes requested changes Aug 30, 2025
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not so sure about this, the impact seems high...

tests/PHPStan/Levels/data/stringOffsetAccess-7.json Outdated
"ignorable": true
},
{
"message": "Offset int|object might not exist on array{baz: 21}|array{foo: 17, bar: 19}.",
Copy link
Member

@ondrejmirtes ondrejmirtes Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong for array{foo: 17, bar: 19}|array{baz: 21}. int|object never exists on these arrays.

Copy link
Contributor Author

@VincentLanglet VincentLanglet Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I think this is because of #4272 which need to be fix/merged first then.

@VincentLanglet VincentLanglet mentioned this pull request Aug 30, 2025
Merged
@VincentLanglet
Copy link
Contributor Author

VincentLanglet commented Sep 3, 2025

Since they are kinda related, #4166 might be better to merge first (?)

@ondrejmirtes ondrejmirtes merged commit 5ca8b49 into phpstan:2.1.x Sep 7, 2025
260 of 261 checks passed
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Sep 7, 2025

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fails to detect possibly-impossible constant offset

3 participants

@VincentLanglet @ondrejmirtes @phpstan-bot