Fix 13296 #4184
Merged
Fix 13296 #4184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
commented
Jul 28, 2025
| } elseif ( | ||
| $node->name instanceof FuncCall | ||
| && $node->name->name instanceof Name | ||
| && $node->name->isFirstClassCallable() |
There was a problem hiding this comment.
Seems like the purpose of this if was to resolve node like
strtoupper(...)($foo)
which is resolved to strtoupper($foo)
but it messed up with foo($bar)($baz)
which was resolved to foo($baz).
VincentLanglet
commented
Jul 28, 2025
| */ | ||
| public function test($a, $b) | ||
| { | ||
| assertType('string', current($a)($b)); |
There was a problem hiding this comment.
Without the fix, the type is understood as current($b) which is int.
|
This pull request has been marked as ready for review. |
|
Thanks |
|
Please use more descriptive PR titles than "Fix 13296" next time. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#13296