Remove DomNode::ownerDocument stub #4197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
VincentLanglet
force-pushed
the
ownerDocument
branch
from
076be0f to
408b698
Compare
|
Please fix conflicts. |
VincentLanglet
force-pushed
the
ownerDocument
branch
from
408b698 to
f06cc71
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to still be nullable:
For instance https://3v4l.org/mMQj8#v8.4.11
According to DOM stubbed properties not working phpstan#8837 this wasn't working anyway.
You also might want to close the issue phpstan/phpstan#8837 since it asked to infer
DomElement::ownerDocumentas non nullable while the 3v4l example is showing it can be null.