Improve TypeCombinator::unionWithSubtractedType #4200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
improveIntersect
branch
from
e91c4f5 to
f222ea6
Compare
VincentLanglet
force-pushed
the
improveIntersect
branch
from
f222ea6 to
5a42acf
Compare
ondrejmirtes
requested changes
Sep 2, 2025
| if ($foo) { | ||
| $date = new \stdClass(); | ||
| } | ||
| assertType('mixed~object~stdClass', $date); |
There was a problem hiding this comment.
I don't know what this means. There should be parentheses to disambiguate.
There was a problem hiding this comment.
This is already the current behavior https://phpstan.org/r/0850c2cb-3c81-4451-b2f6-b570d1d41a30
I'll see what I can do
VincentLanglet
force-pushed
the
improveIntersect
branch
from
9f8c741 to
ed8df0e
Compare
VincentLanglet
commented
Sep 2, 2025
| trait SubstractableTypeTrait | ||
| { | ||
|
|
||
| public function describeSubtractedType(?Type $subtractedType, VerbosityLevel $level): string |
There was a problem hiding this comment.
I dunno if it's worth to add this method to the interface (I didn't) but since the logic was used 5 times I thought it could been useful to have a specific method (for later updates ?)
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While thinking about phpstan/phpstan#12390 I just decovered the weird behavior
https://phpstan.org/r/0850c2cb-3c81-4451-b2f6-b570d1d41a30
I expect
mixed~object~stdclass & objectto bestdClass.