fix: place UniversalObjectCratesClassReflectionExtension last #4207
+30
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
None of the failed jobs look like they came from these changes? Let me know if I need to change anything though! |
|
Fix the lint job by |
|
@staabm, I can do that, but that's from a file upstream that wasn't touched in this PR |
|
The changes are fine, I just don't understand why this has to be E2E test. It could be just a test for a specific rule. The config doesn't even add anything, stdClass is already universal object crate. |
|
Ah, I just wasn't sure where to put the test, is there a specific location you would like it to go? |
|
Looking at the bug report simply putting the file in tests/PHPStan/Analyser/nsrt should be fine |
This moves the UniversalObjectCratesClassReflectionExtension to the very end of the extensions to give other extensions a chance to override.
calebdw
force-pushed
the
calebdw/push-qwwyztoormwo
branch
from
b28ea6c to
820a955
Compare
|
Awesome, I've updated |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This moves the UniversalObjectCratesClassReflectionExtension to the very end of the extensions to give other extensions a chance to override.
Closes phpstan/phpstan#13342
Thanks!