POC: Use SimultaneousTypeTraverser in RuleLevelHelper::transformAcceptedType #4210
+70
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static analysis is failing because TypeTraverserInstanceofVisitor doesn't support SimultaneousTypeTraverser (not sure it should).
The only current test failing is
but I feel like we could reproduce more errors because...
UnionType/Intersection types doesn't work well with the SimultaneousTypeTraverser because
A&B&C
andA
we're not traversing because second type is not an IntersectionA&B&C
andA&C
we're not traversing because types count are differentThe main issue would be, when traversing
A&B&C
andA&C
, to match types in order to