Make DOMNamedNodeMap generic

[stefanfisk]

Resolves phpstan/phpstan#13365.

[VincentLanglet]

It shouldn't need to implements both Traversable and IteratorAggregate in the stub.

See
https://github.com/JetBrains/phpstorm-stubs/blob/6c034ae018ed7ac2cacf2474f824aede73658afa/dom/dom_c.php#L1381

[stefanfisk]

@VincentLanglet I just copied it from DOMNodeList at

phpstan-src/stubs/dom.stub

Line 75 in c0e6f0e

class DOMNodeList implements Traversable, IteratorAggregate, Countable

Do you want me to fix DOMNodeList as well?

[VincentLanglet]

If it's done this way for DOMNodeList you can just ignore my remark I think

[ondrejmirtes]

Please fix both DOMNodeList and DOMNamedNodeMap here.

There are some classes where it'd make sense because of the logic here https://github.com/ondrejmirtes/BetterReflection/blob/61b25baaca1ea904447f46d975a4ae7c99b722e6/src/SourceLocator/SourceStubber/PhpStormStubsSourceStubber.php#L528-L574, but it's not true for any DOM* classes.

[stefanfisk]

I've now removed Traversable from all DOM classes.

[ondrejmirtes]

Additionally please add DOMNamedNodeMap to

phpstan-src/conf/config.neon

Line 29 in 5a39902

skipCheckGenericClasses: []

skipCheckGenericClasses array.

[stefanfisk]

I added DOMNamedNodeMap to skipCheckGenericClasses. What does it do?

[ondrejmirtes]

I added DOMNamedNodeMap to skipCheckGenericClasses. What does it do?

Normally generic classes are required to specify the generic tempalte types in all typehints. So @param DOMNamedNodeMap $a is not sufficient, you need to type @param DOMNamedNodeMap<X> $a.

But making a non-generic class generic in a non-major PHPStan version is a BC break, that's where skipCheckGenericClasses comes in. It skips this requirement for the listed classes.

[ondrejmirtes]

Thank you.