Skip to content

Fix build #4214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
Merged

Fix build #4214

merged 1 commit into from
Aug 7, 2025

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Aug 7, 2025

fixes php 7.4 only errors:

There were 3 failures:

1) PHPStan\Reflection\ClassReflectionTest::testIsAttributeClass with data set #2 ('Attributes\IsAttribute2', true, 128)
Failed asserting that 64 is identical to 128.

/home/runner/work/phpstan-src/phpstan-src/tests/PHPStan/Reflection/ClassReflectionTest.php:181
/home/runner/work/phpstan-src/phpstan-src/tests/vendor/phpunit/phpunit/src/TextUI/Command.php:146

2) PHPStan\Reflection\ClassReflectionTest::testIsAttributeClass with data set #1 ('Attributes\IsAttribute', true)
Failed asserting that 63 is identical to 127.

/home/runner/work/phpstan-src/phpstan-src/tests/PHPStan/Reflection/ClassReflectionTest.php:181
/home/runner/work/phpstan-src/phpstan-src/tests/vendor/phpunit/phpunit/src/TextUI/Command.php:146

3) PHPStan\Reflection\ClassReflectionTest::testIsAttributeClass with data set #3 ('Attributes\IsAttribute3', true, 136)
Failed asserting that 72 is identical to 136.

/home/runner/work/phpstan-src/phpstan-src/tests/PHPStan/Reflection/ClassReflectionTest.php:181
/home/runner/work/phpstan-src/phpstan-src/tests/vendor/phpunit/phpunit/src/TextUI/Command.php:146

https://github.com/phpstan/phpstan-src/actions/runs/16799140529/job/47576177091

@ondrejmirtes ondrejmirtes merged commit cb8cead into phpstan:2.1.x Aug 7, 2025
276 of 277 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@staabm staabm deleted the fix74 branch August 7, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants