Skip to content

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Aug 8, 2025

1) PHPStan\Reflection\ReflectionProviderGoldenTest::test with data set "METHOD SolrParams::serialize" ('METHOD SolrParams::serialize', 'Is final: Yes\nIs built-in: Y... mixed')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 'Is final: Yes
 Is built-in: Yes
 Has side-effects: Maybe
+Throw type: Exception
 Visibility: public
 Variants: 1
     /**

/home/runner/work/phpstan-src/phpstan-src/tests/PHPStan/Reflection/ReflectionProviderGoldenTest.php:73

2) PHPStan\Reflection\ReflectionProviderGoldenTest::test with data set "METHOD SolrDisMaxQuery::serialize" ('METHOD SolrDisMaxQuery::serialize', 'Is final: Yes\nIs built-in: Y... mixed')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 'Is final: Yes
 Is built-in: Yes
 Has side-effects: Maybe
+Throw type: Exception
 Visibility: public
 Variants: 1
     /**

/home/runner/work/phpstan-src/phpstan-src/tests/PHPStan/Reflection/ReflectionProviderGoldenTest.php:73

3) PHPStan\Reflection\ReflectionProviderGoldenTest::test with data set "METHOD SolrQuery::serialize" ('METHOD SolrQuery::serialize', 'Is final: Yes\nIs built-in: Y... mixed')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 'Is final: Yes
 Is built-in: Yes
 Has side-effects: Maybe
+Throw type: Exception
 Visibility: public
 Variants: 1
     /**

/home/runner/work/phpstan-src/phpstan-src/tests/PHPStan/Reflection/ReflectionProviderGoldenTest.php:73

Seems ok

Could be interesting to have some automation which try to remove each line one by one and if there is no diff in golden tests generate a PR.

@VincentLanglet VincentLanglet force-pushed the solr-2 branch 4 times, most recently from f80884c to 8f1005d Compare August 8, 2025 16:22
@VincentLanglet VincentLanglet marked this pull request as ready for review August 8, 2025 16:31
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@ondrejmirtes ondrejmirtes merged commit bd10157 into phpstan:2.1.x Aug 13, 2025
448 of 453 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants