Better support for -0.0 #4228
Open
Better support for -0.0 #4228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
poc/12225
branch
from
7fe1a6a to
9ae0da1
Compare
VincentLanglet
force-pushed
the
poc/12225
branch
from
9ae0da1 to
f6132e5
Compare
VincentLanglet
force-pushed
the
poc/12225
branch
3 times, most recently
from
95bedc0 to
d183265
Compare
VincentLanglet
force-pushed
the
poc/12225
branch
from
d183265 to
a683afb
Compare
|
This pull request has been marked as ready for review. |
|
in phpstan/phpstan#12225 (comment) you mentioned a always-true check. will this error be reported after this PR and needs to be test-covered? |
No, but it's finally another issue because you already has the issue with something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be a solution for the issue phpstan/phpstan#12225
0.0and-0.0since they have a different toString value=== 0.0like=== 0.0 || === -0.0== 0The other solution I had in mind for the issue was to "just" update ConstantFloat::toString but it has the drawback that
would have been considered as
'0.0'|'-0.0'while here the constant was really known.Closes phpstan/phpstan#12225
What could be done to have less changes, would be to modify UnionType::describe to merge 0.0 and -0.0.
But I feel like it's better to be explicit, (since 0.0 and -0.0 have a different behavior) and also, there is already some
-0.0displayed by PHPStan like in the following snippet (and you'll see the already existing inconsistency).https://phpstan.org/r/0b3cdd4f-b228-4272-a685-621afcf21dd5
cc @staabm (cause I feel like you worked a lot on strict/loose comparison.