Remove useless reflection stubs

[VincentLanglet]

PHPStan\Reflection\ReflectionProviderGoldenTest::test with data set "METHOD ReflectionExtension::isPersistent" ('METHOD ReflectionExtension::i...istent', 'Is built-in: Yes\nHas side-ef... mixed')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 'Is built-in: Yes
-Has side-effects: Yes
 Visibility: public
 Variants: 1
     /**
-     * @return void
+     * @return bool
      */
     function isPersistent(): mixed'

/home/runner/work/phpstan-src/phpstan-src/tests/PHPStan/Reflection/ReflectionProviderGoldenTest.php:73

It's a fix: https://www.php.net/manual/fr/reflectionextension.ispersistent.php

PHPStan\Reflection\ReflectionProviderGoldenTest::test with data set "METHOD ReflectionGenerator::getThis" ('METHOD ReflectionGenerator::getThis', 'Is built-in: Yes\nVisibility:... mixed')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 Visibility: public
 Variants: 1
     /**
-     * @return object
+     * @return object|null
      */
     function getThis(): mixed'

/home/runner/work/phpstan-src/phpstan-src/tests/PHPStan/Reflection/ReflectionProviderGoldenTest.php:73

It's a fix: https://www.php.net/manual/fr/reflectiongenerator.getthis.php

PHPStan\Reflection\ReflectionProviderGoldenTest::test with data set "METHOD ReflectionExtension::getVersion" ('METHOD ReflectionExtension::getVersion', 'Is built-in: Yes\nVisibility:... mixed')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 Visibility: public
 Variants: 1
     /**
-     * @return string
+     * @return string|null
      */
     function getVersion(): mixed'

/home/runner/work/phpstan-src/phpstan-src/tests/PHPStan/Reflection/ReflectionProviderGoldenTest.php:73

It's a fix https://www.php.net/manual/en/reflectionextension.getversion.php

And others are like

PHPStan\Reflection\ReflectionProviderGoldenTest::test with data set "METHOD ReflectionParameter::__construct" ('METHOD ReflectionParameter::_...struct', 'Is built-in: Yes\nHas side-ef... mixed')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
     /**
      * @param array|object|string $function
      * @param int|string $param
-     * @return void
+     * @return mixed
      */
     function __construct(mixed $function, int|string $param): mixed'

/home/runner/work/phpstan-src/phpstan-src/tests/PHPStan/Reflection/ReflectionProviderGoldenTest.php:73

Do we care bout construct return type ?

[phpstan-bot]

This pull request has been marked as ready for review.

[phpstan-bot]

This pull request has been marked as ready for review.

[VincentLanglet]

Build 8.5 will be solved by #4230

[ondrejmirtes]

Thank you!

[ondrejmirtes]

Hey, I really welcome these changes but they have one downside - we're losing original parameter names on 7.4. Which will change users' baselines.

Please focus on more obscure extensions like solr was, instead of changing entries

[ondrejmirtes]

...that everybody uses. Thanks 😊