Improve str_replace return type
#4242
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
which error is this PR trying to solve? can you reproduce the error/problem on phpstan.org/try ? |
|
How can I create a try reproducible with the config |
|
I see. you cannot set a config flag on phpstan.org/try. please add a test-case in ReturnTypeRuleTest which fails without your fix |
|
For the record, the computed type is done in a dynamic return type extension and there is already a PR which does some improvement on it #4023 That might not solve your issue thought, but be aware of conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the config
checkBenevolentUnionTypesis enabled thestr_replacestarts to always reporting the return asstring|list<string>but in reality the return depends on the$subjectparam type.