Update RangeFunctionReturnTypeExtension to include known integer ranges for keys #4251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrinsFrank
force-pushed
the
range-returns-list-with-known-nr-of-elements
branch
from
783dac8 to
884429f
Compare
|
Misses a type-inference test which fails without the patch using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the
rangefunction returns a list Type for large numbers. we can narrow this down, because we do actually know the upper and lower bounds of the keys, by subtracting the lower bound from the upper bound and dividing that by the step number.I think this covers all scenarios, let me know if I've missed anything!