Skip to content

fix build #4258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2025
Merged

fix build #4258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48eb91b
fix build
staabm Aug 26, 2025
3e856e3
fix
staabm Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions tests/PHPStan/Rules/Methods/CallToMethodStatementWithoutSideEffectsRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use PHPStan\Rules\Rule;
use PHPStan\Rules\RuleLevelHelper;
use PHPStan\Testing\RuleTestCase;
use PHPUnit\Framework\Attributes\RequiresPhp;
use function array_merge;
use const PHP_VERSION_ID;

Expand All @@ -19,7 +20,31 @@ protected function getRule(): Rule
return new CallToMethodStatementWithoutSideEffectsRule(new RuleLevelHelper(self::createReflectionProvider(), true, false, true, false, false, false, true));
}

#[RequiresPhp('>= 8.0')]
public function testRule(): void
{
$this->analyse([__DIR__ . '/data/method-call-statement-no-side-effects.php'], [
[
'Call to method DateTimeImmutable::modify() on a separate line has no effect.',
15,
],
[
'Call to method Exception::getCode() on a separate line has no effect.',
21,
],
[
'Call to method MethodCallStatementNoSideEffects\Bar::doPure() on a separate line has no effect.',
63,
],
[
'Call to method MethodCallStatementNoSideEffects\Bar::doPureWithThrowsVoid() on a separate line has no effect.',
64,
],
]);
}

#[RequiresPhp('< 8')]
public function testRulePhp7(): void
{
$this->analyse([__DIR__ . '/data/method-call-statement-no-side-effects.php'], [
[
Expand Down
13 changes: 13 additions & 0 deletions tests/PHPStan/Rules/Methods/CallToStaticMethodStatementWithoutSideEffectsRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use PHPStan\Rules\Rule;
use PHPStan\Rules\RuleLevelHelper;
use PHPStan\Testing\RuleTestCase;
use PHPUnit\Framework\Attributes\RequiresPhp;

/**
* @extends RuleTestCase<CallToStaticMethodStatementWithoutSideEffectsRule>
Expand All @@ -21,7 +22,19 @@ protected function getRule(): Rule
);
}

#[RequiresPhp('>= 8.0')]
public function testRule(): void
{
$this->analyse([__DIR__ . '/data/static-method-call-statement-no-side-effects.php'], [
[
'Call to method DateTime::format() on a separate line has no effect.',
23,
],
]);
}

#[RequiresPhp('< 8')]
public function testRulePhp7(): void
{
$this->analyse([__DIR__ . '/data/static-method-call-statement-no-side-effects.php'], [
[
Expand Down
Loading