Skip to content

Prevent "Unsafe usage of new static() in abstract class" with final constructor #4265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Prevent "Unsafe usage of new static() in abstract class" with final constructor #4265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Rules/Classes/NewStaticInAbstractClassStaticMethodRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,15 @@ public function processNode(Node $node, Scope $scope): array
return [];
}

if ($classReflection->hasConstructor()) {
$constructor = $classReflection->getConstructor();
if (
$constructor->isFinal()->yes()
) {
return [];
}
}

return [
RuleErrorBuilder::message(sprintf(
'Unsafe usage of new static() in abstract class %s in static method %s().',
Expand Down
20 changes: 20 additions & 0 deletions tests/PHPStan/Rules/Classes/data/new-static-in-abstract-class-static-method.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,23 @@ public static function staticDoFoo(): void
}

}

abstract class FinalConstructFoo
{
final function __construct() {

}

public function doFoo(): void
{
new static();
}

public static function staticDoFoo(): void
{
new static();
}

}

class Subclass extends FinalConstructFoo {}
Loading