Fix hasOffsetValueType for arrays #4277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
commented
Sep 2, 2025
| @@ -1801,7 +1801,7 @@ public static function dataProperties(): array | |||
| '$this->resource', | |||
| ], | |||
| [ | |||
| '*ERROR*', | |||
| 'mixed', | |||
There was a problem hiding this comment.
This change revert the one in #4272
| @@ -193,10 +193,6 @@ public function testStrings(): void | |||
| 'Offset 12.34 might not exist on array|string.', | |||
| 28, | |||
| ], | |||
| [ | |||
| 'Offset int|object might not exist on array|string.', | |||
There was a problem hiding this comment.
This error was added by #4272
It make sens to not have it since
- int is a valid offset and produce no error
- object is not a valid offset (and produce a php crash) and is already reported by the InvalidArrayOffsetRule.
| @@ -932,10 +928,6 @@ public function testBugObject(): void | |||
| 'Offset int|object does not exist on array{baz: 21}|array{foo: 17, bar: 19}.', | |||
| 12, | |||
| ], | |||
| [ | |||
| 'Offset object does not exist on array<string, int>.', | |||
There was a problem hiding this comment.
Same, already reported by InvalidArrayOffsetRule and this was added by #4272
VincentLanglet
force-pushed
the
fixHasOffsetValueType
branch
from
c66a340 to
8ff0adb
Compare
|
The 7.4 failure already exists on 2.1.x https://github.com/phpstan/phpstan-src/actions/runs/17398668843/job/49386473327 |
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Sep 2, 2025
| @@ -18,10 +18,5 @@ | |||
| "message": "Invalid array key type stdClass.", | |||
| "line": 59, | |||
| "ignorable": true | |||
| }, | |||
| { | |||
| "message": "Offset stdClass does not exist on array{baz: 21}|array{foo: 17, bar: 19}.", | |||
There was a problem hiding this comment.
We're losing these useful errors. What are they replaced with?
There was a problem hiding this comment.
There is already (above)
Invalid array key type stdClass.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like we should only check for AllowedArrayKeysTypes since others types are checked by InvalidArrayKey rule.