Skip to content

Faster ArrayType->hasOffsetValueType() #4288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2025
Merged

Faster ArrayType->hasOffsetValueType() #4288

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6dab64
Faster ArrayType->hasOffsetValueType()
staabm Sep 5, 2025
dc6e2c0
Update ConstantArrayType.php
staabm Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Type/ArrayType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,12 @@ public function looseCompare(Type $type, PhpVersion $phpVersion): BooleanType

public function hasOffsetValueType(Type $offsetType): TrinaryLogic
{
$allowedArrayKeys = AllowedArrayKeysTypes::getType();
$offsetType = TypeCombinator::intersect($allowedArrayKeys, $offsetType)->toArrayKey();
$offsetArrayKeyType = $offsetType->toArrayKey();
if ($offsetArrayKeyType instanceof ErrorType) {
$allowedArrayKeys = AllowedArrayKeysTypes::getType();
$offsetArrayKeyType = TypeCombinator::intersect($allowedArrayKeys, $offsetType)->toArrayKey();
}
$offsetType = $offsetArrayKeyType;

if ($this->getKeyType()->isSuperTypeOf($offsetType)->no()
&& ($offsetType->isString()->no() || !$offsetType->isConstantScalarValue()->no())
Expand Down
Loading