Skip to content

Conversation

gharlan
Copy link
Contributor

@gharlan gharlan commented Sep 9, 2025

Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this looks great. I just pushed a commit here with how I imagine the tests to look like. Please add tests for all the branches you added to the code. Thanks!

@ondrejmirtes ondrejmirtes merged commit f86709c into phpstan:2.1.x Sep 10, 2025
447 of 456 checks passed
@ondrejmirtes
Copy link
Member

Thank you! Now you can rebase your other PR 😊

@gharlan gharlan deleted the ignore-errors-validation branch September 10, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants