-
Notifications
You must be signed in to change notification settings - Fork 540
Remember narrowed readonly types in anonymous functions #4313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e23ee0b
Remember narrowed readonly types in anonymous functions
staabm 33e8c09
test readonly class
staabm a830aa6
test static anonyous functions
staabm b234215
only in immediately invoked
staabm 5f9d68c
fix
staabm 98f5558
simplify diff
staabm 54db532
prevent duplicated work
staabm 2422f94
fix
staabm c540180
re-use logic from preparational PR
staabm cabf11d
rebase
staabm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
<?php // lint >= 8.1 | ||
|
||
namespace Bug13321; | ||
|
||
use function PHPStan\Testing\assertType; | ||
|
||
class Foo | ||
{ | ||
public function __construct(public readonly string $value) | ||
{ | ||
} | ||
} | ||
|
||
class Bar | ||
{ | ||
public function __construct( | ||
private readonly ?Foo $foo, | ||
private ?Foo $writableFoo = null, | ||
) | ||
{ | ||
} | ||
|
||
public function bar(): void | ||
{ | ||
(function () { | ||
assertType(Foo::class.'|null', $this->foo); | ||
assertType(Foo::class.'|null', $this->writableFoo); | ||
|
||
echo $this->foo->value; | ||
})(); | ||
|
||
if ($this->foo === null) { | ||
return; | ||
} | ||
if ($this->writableFoo === null) { | ||
return; | ||
} | ||
|
||
(function () { | ||
assertType(Foo::class, $this->foo); | ||
assertType(Foo::class.'|null', $this->writableFoo); | ||
|
||
echo $this->foo->value; | ||
})(); | ||
|
||
$test = function () { | ||
assertType(Foo::class, $this->foo); | ||
assertType(Foo::class.'|null', $this->writableFoo); | ||
|
||
echo $this->foo->value; | ||
}; | ||
|
||
$test(); | ||
|
||
$test = static function () { | ||
assertType('mixed', $this->foo); | ||
assertType('mixed', $this->writableFoo); | ||
|
||
echo $this->foo->value; | ||
}; | ||
|
||
$test(); | ||
} | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
<?php // lint >= 8.2 | ||
|
||
namespace Bug13321b; | ||
|
||
use function PHPStan\Testing\assertType; | ||
|
||
class Foo | ||
{ | ||
public function __construct( | ||
public string $value, | ||
readonly public string $readonlyValue, | ||
) | ||
{ | ||
} | ||
} | ||
|
||
readonly class Bar | ||
{ | ||
public function __construct( | ||
private ?Foo $foo, | ||
) | ||
{ | ||
} | ||
|
||
public function bar(): void | ||
{ | ||
if ($this->foo === null) { | ||
return; | ||
} | ||
if ($this->foo->value === '') { | ||
return; | ||
} | ||
if ($this->foo->readonlyValue === '') { | ||
return; | ||
} | ||
|
||
assertType(Foo::class, $this->foo); | ||
assertType('non-empty-string', $this->foo->value); | ||
assertType('non-empty-string', $this->foo->readonlyValue); | ||
|
||
$test = function () { | ||
assertType(Foo::class, $this->foo); | ||
assertType('string', $this->foo->value); | ||
assertType('non-empty-string', $this->foo->readonlyValue); | ||
}; | ||
|
||
$test(); | ||
} | ||
|
||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.