RuleTestCase - parse errors from files #4335
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing line numbers of errors in tests is very annoying. It also makes it impractical to add anything before the last error (e.g. group errors logically) because then all past errors need to be renumbered. This PR fixes this problem by parsing the errors directly from files.
I've considered using a separate method instead of
$expectedErrors = null
but this is quite handy especially with data providers as shown indataBug4969()
: detect errors with some setting, no errors without that setting.I've used this on two random places. I can try to refactor more if there's an interest.