Skip to content

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet force-pushed the fix/7927 branch 4 times, most recently from 5467bcc to 1428e9b Compare September 15, 2025 19:32
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to catch LogicException. The right way to prevent this is to contribute something like hasValueExpression first to https://github.com/ondrejmirtes/BetterReflection to prevent the error.

Please note that contributing to that fork is a bit tricky. The last two commits are always "[GENERATED] Renamed" and "[GENERATED] Downgrading".

You need to start by git reset --hard before these two commits. Then make your changes. Then run make downgrade-inner (and commit that) and make rename-inner (and commit that).

Please note that the CI there isn't green. The library could appreciate some love but given it's only just me working on the fork I didn't prioritize that yet.

@VincentLanglet
Copy link
Contributor Author

@ondrejmirtes
Copy link
Member

I actually disagree with merging Roave/BetterReflection#1527 instead of Roave/BetterReflection#1528.

Since hasValueExpression was already added on Roave/BetterReflection#1526 it should have just been added on the adapter as well.

I'll rebase the fork and adjust it to my taste.

@ondrejmirtes
Copy link
Member

Updated here.

@VincentLanglet
Copy link
Contributor Author

Updated here.

Thanks, rebased and updated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error "Internal error: This enum case does not have a value in file"
3 participants