-
Notifications
You must be signed in to change notification settings - Fork 534
Avoid crashing on enum without value #4336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.1.x
Are you sure you want to change the base?
Conversation
5467bcc
to
1428e9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to catch LogicException. The right way to prevent this is to contribute something like hasValueExpression
first to https://github.com/ondrejmirtes/BetterReflection to prevent the error.
Please note that contributing to that fork is a bit tricky. The last two commits are always "[GENERATED] Renamed" and "[GENERATED] Downgrading".
You need to start by git reset --hard
before these two commits. Then make your changes. Then run make downgrade-inner
(and commit that) and make rename-inner
(and commit that).
Please note that the CI there isn't green. The library could appreciate some love but given it's only just me working on the fork I didn't prioritize that yet.
1428e9b
to
f6157ba
Compare
I actually disagree with merging Roave/BetterReflection#1527 instead of Roave/BetterReflection#1528. Since I'll rebase the fork and adjust it to my taste. |
Updated here. |
a62d108
to
33a4ebb
Compare
Thanks, rebased and updated :) |
Closes phpstan/phpstan#7927