Skip to content

Mark Memcached:: methods as impure. #4344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.1.x
Choose a base branch
from
Open

Mark Memcached:: methods as impure. #4344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions bin/functionMetadata_original.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,41 @@
'DateTimeImmutable::getTimestamp' => ['hasSideEffects' => false],
'DateTimeImmutable::getTimezone' => ['hasSideEffects' => false],

'Memcached::add' => ['hasSideEffects' => true],
'Memcached::addByKey' => ['hasSideEffects' => true],
'Memcached::append' => ['hasSideEffects' => true],
'Memcached::appendByKey' => ['hasSideEffects' => true],
'Memcached::cas' => ['hasSideEffects' => true],
'Memcached::casByKey' => ['hasSideEffects' => true],
'Memcached::decrement' => ['hasSideEffects' => true],
'Memcached::decrementByKey' => ['hasSideEffects' => true],
'Memcached::delete' => ['hasSideEffects' => true],
'Memcached::deleteByKey' => ['hasSideEffects' => true],
'Memcached::deleteMulti' => ['hasSideEffects' => true],
'Memcached::deleteMultiByKey' => ['hasSideEffects' => true],
'Memcached::fetch' => ['hasSideEffects' => true],
'Memcached::fetchAll' => ['hasSideEffects' => true],
'Memcached::flush' => ['hasSideEffects' => true],
'Memcached::get' => ['hasSideEffects' => true],
'Memcached::getByKey' => ['hasSideEffects' => true],
'Memcached::getDelayed' => ['hasSideEffects' => true],
'Memcached::getDelayedByKey' => ['hasSideEffects' => true],
'Memcached::getMulti' => ['hasSideEffects' => true],
'Memcached::getMultiByKey' => ['hasSideEffects' => true],
'Memcached::getServerByKey' => ['hasSideEffects' => true],
Comment on lines +188 to +194
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does get method has side effects too ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VincentLanglet I'm sorry, which "get" method?
The getServerByKey, where your comment is located has the side effect: https://www.php.net/manual/en/memcached.getserverbykey.php#refsect1-memcached.getserverbykey-returnvalues

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant all the getFoo method sonce they arr just getter

But if I understand correctly they all have side effect because they have impact on the getResultCode

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VincentLanglet exactly. I think that i've marked all methods that change getResultCode.

'Memcached::increment' => ['hasSideEffects' => true],
'Memcached::incrementByKey' => ['hasSideEffects' => true],
'Memcached::prepend' => ['hasSideEffects' => true],
'Memcached::prependByKey' => ['hasSideEffects' => true],
'Memcached::replace' => ['hasSideEffects' => true],
'Memcached::replaceByKey' => ['hasSideEffects' => true],
'Memcached::set' => ['hasSideEffects' => true],
'Memcached::setByKey' => ['hasSideEffects' => true],
'Memcached::setMulti' => ['hasSideEffects' => true],
'Memcached::setMultiByKey' => ['hasSideEffects' => true],
'Memcached::touch' => ['hasSideEffects' => true],
'Memcached::touchByKey' => ['hasSideEffects' => true],

// affects isConnected()
'Redis::connect' => ['hasSideEffects' => true],
'Redis::pconnect' => ['hasSideEffects' => true],
Expand Down
34 changes: 34 additions & 0 deletions resources/functionMetadata.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,40 @@
'JsonIncrementalParser::__construct' => ['hasSideEffects' => false],
'JsonIncrementalParser::get' => ['hasSideEffects' => false],
'JsonIncrementalParser::getError' => ['hasSideEffects' => false],
'Memcached::add' => ['hasSideEffects' => true],
'Memcached::addByKey' => ['hasSideEffects' => true],
'Memcached::append' => ['hasSideEffects' => true],
'Memcached::appendByKey' => ['hasSideEffects' => true],
'Memcached::cas' => ['hasSideEffects' => true],
'Memcached::casByKey' => ['hasSideEffects' => true],
'Memcached::decrement' => ['hasSideEffects' => true],
'Memcached::decrementByKey' => ['hasSideEffects' => true],
'Memcached::delete' => ['hasSideEffects' => true],
'Memcached::deleteByKey' => ['hasSideEffects' => true],
'Memcached::deleteMulti' => ['hasSideEffects' => true],
'Memcached::deleteMultiByKey' => ['hasSideEffects' => true],
'Memcached::fetch' => ['hasSideEffects' => true],
'Memcached::fetchAll' => ['hasSideEffects' => true],
'Memcached::flush' => ['hasSideEffects' => true],
'Memcached::get' => ['hasSideEffects' => true],
'Memcached::getByKey' => ['hasSideEffects' => true],
'Memcached::getDelayed' => ['hasSideEffects' => true],
'Memcached::getDelayedByKey' => ['hasSideEffects' => true],
'Memcached::getMulti' => ['hasSideEffects' => true],
'Memcached::getMultiByKey' => ['hasSideEffects' => true],
'Memcached::getServerByKey' => ['hasSideEffects' => true],
'Memcached::increment' => ['hasSideEffects' => true],
'Memcached::incrementByKey' => ['hasSideEffects' => true],
'Memcached::prepend' => ['hasSideEffects' => true],
'Memcached::prependByKey' => ['hasSideEffects' => true],
'Memcached::replace' => ['hasSideEffects' => true],
'Memcached::replaceByKey' => ['hasSideEffects' => true],
'Memcached::set' => ['hasSideEffects' => true],
'Memcached::setByKey' => ['hasSideEffects' => true],
'Memcached::setMulti' => ['hasSideEffects' => true],
'Memcached::setMultiByKey' => ['hasSideEffects' => true],
'Memcached::touch' => ['hasSideEffects' => true],
'Memcached::touchByKey' => ['hasSideEffects' => true],
'MemcachedException::__construct' => ['hasSideEffects' => false],
'MessageFormatter::__construct' => ['hasSideEffects' => false],
'MessageFormatter::format' => ['hasSideEffects' => false],
Expand Down
5 changes: 5 additions & 0 deletions tests/PHPStan/Rules/Comparison/StrictComparisonOfDifferentTypesRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1040,4 +1040,9 @@ public function testBug11609(): void
]);
}

public function testBug13444(): void
{
$this->analyse([__DIR__ . '/data/bug-13444.php'], []);
}

}
Loading
Loading