Skip to content

Add non regression test for issue 9386 #4348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2025
Merged

Add non regression test for issue 9386 #4348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d604418
Add non regression test for 9386
VincentLanglet Sep 19, 2025
595848e
Fix lint
VincentLanglet Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/PHPStan/Rules/Operators/InvalidComparisonOperationRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,11 @@ public function testBug13001(): void
]);
}

public function testBug9386(): void
{
$this->analyse([__DIR__ . '/data/bug-9386.php'], []);
}

public function testBug7280Comment(): void
{
$this->analyse([__DIR__ . '/data/bug-7280-comment.php'], []);
Expand Down
29 changes: 29 additions & 0 deletions tests/PHPStan/Rules/Operators/data/bug-9386.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?php // lint >= 8.0

declare(strict_types = 1);

namespace Bug9386;

trait BaseTrait {
protected false|int $_pos;

public function myMethod():bool {
$pos = $this->_pos;
if ($pos === false)
return false;
if (($this instanceof BaseClass) && $this->length !== null)
return $pos >= $this->offset + $this->length;
return false;
}
}

class BaseClass
{
use BaseTrait;
protected ?int $length = null;
protected int $offset = 0;
}
class SecondClass
{
use BaseTrait;
}
Loading