False positive "non-empty-array<int, int> might not be a list" when change existing list key #4351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
force-pushed
the
bug13035
branch
2 times, most recently
from
40597c5 to
c56e097
Compare
|
This pull request has been marked as ready for review. |
staabm
commented
Sep 21, 2025
Comment on lines
+5701
to
+5629
| if ( | ||
| $var === $originalVar | ||
| && $var->dim !== null | ||
| && $scope->hasExpressionType($var)->yes() | ||
| ) { | ||
| $assignedPropertyExpr = new SetExistingOffsetValueTypeExpr( | ||
| $varForSetOffsetValue, | ||
| $var->dim, | ||
| $assignedPropertyExpr, | ||
| ); | ||
| } else { | ||
| $assignedPropertyExpr = new SetOffsetValueTypeExpr( | ||
| $varForSetOffsetValue, | ||
| $var->dim, | ||
| $assignedPropertyExpr, | ||
| ); | ||
| } |
There was a problem hiding this comment.
with this change, we make sure PropertyAssignNode contains a proper type.
we already had the right type in scope from a previous fix.
staabm
force-pushed
the
bug13035
branch
3 times, most recently
from
976d0e8 to
83c5e5d
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#13035