Skip to content

Dynamic return type for DOM::appendChild and similar methods #4354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
+37 −0
Merged

Dynamic return type for DOM::appendChild and similar methods #4354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions stubs/dom.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,27 @@ class DOMNode
*/
public function hasAttributes() {}

/**
* @template TNode of DOMNode
* @param TNode $node
* @return __benevolent<TNode|false>
*/
public function insertBefore(DOMNode $node, ?DOMNode $child = null) {}

/**
* @template TNode of DOMNode
* @param TNode $node
* @return __benevolent<TNode|false>
*/
public function removeChild(DOMNode $node) {}

/**
* @template TNode of DOMNode
* @param TNode $node
* @return __benevolent<TNode|false>
*/
public function appendChild(DOMNode $node) {}

}

class DOMElement extends DOMNode
Expand Down
16 changes: 16 additions & 0 deletions tests/PHPStan/Analyser/nsrt/bug-9200.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?php

namespace Bug9200;

use function PHPStan\Testing\assertType;

function test(\DOMElement $element, \DOMNode $node): void
{
assertType('(DOMElement|false)', $node->appendChild($element));
assertType('(DOMNode|false)', $element->appendChild($node));
assertType('(DOMElement|false)', $node->removeChild($element));
assertType('(DOMNode|false)', $element->removeChild($node));
assertType('(DOMElement|false)', $node->insertBefore($element, $node));
assertType('(DOMNode|false)', $node->insertBefore($node, $element));
assertType('(DOMNode|false)', $element->insertBefore($node, $node));
}
Loading