Restrict accepted args of php_uname() #4359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now throws an error in PHP 8.4 when invalid args are given. See https://www.php.net/manual/en/function.php-uname.php
staabm
reviewed
Sep 22, 2025
|
I believe that's a regression for phpstan, and that it should go in the 8.4-specific functionMap, so if you are validating for earlier versions it should not error. But that might be negligible.. so wait for the boss review :) |
|
Well, the function still won't work as expected on <8.4 with wrong arguments |
ondrejmirtes
requested changes
Sep 25, 2025
resources/functionMap.php
Outdated
| 'php_sapi_name' => ['__benevolent<non-empty-string|false>'], | ||
| 'php_strip_whitespace' => ['string', 'file_name'=>'string'], | ||
| 'php_uname' => ['string', 'mode='=>'string'], | ||
| 'php_uname' => ['string', 'mode='=>'"a"|"s"|"n"|"r"|"v"|"m"'], |
There was a problem hiding this comment.
I don't accept parameter type restrictions outside of bleeding edge. Because this would require users to also narrow down their PHPDocs when they're currently just passing string there.
So this change belongs to resources/functionMap_bleedingEdge.php.
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now throws an error in PHP 8.4 when invalid args are given.
See https://www.php.net/manual/en/function.php-uname.php