Skip to content

Fix DOMNode::C14N bad definition #4361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 2.1.x
Choose a base branch
from
Open

Fix DOMNode::C14N bad definition #4361

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
253fc33
Remove two bad definition
VincentLanglet Sep 22, 2025
2ed5ff6
Fix
VincentLanglet Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/functionMap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1606,8 +1606,8 @@
'DomNode::add_namespace' => ['bool', 'uri'=>'string', 'prefix'=>'string'],
'DomNode::append_child' => ['__benevolent<DOMNode|false>', 'newnode'=>'DOMNode'],
'DOMNode::appendChild' => ['__benevolent<DOMNode|false>', 'newnode'=>'DOMNode'],
'DOMNode::C14N' => ['string', 'exclusive='=>'bool', 'with_comments='=>'bool', 'xpath='=>'array', 'ns_prefixes='=>'array'],
'DOMNode::C14NFile' => ['int', 'uri='=>'string', 'exclusive='=>'bool', 'with_comments='=>'bool', 'xpath='=>'array', 'ns_prefixes='=>'array'],
'DOMNode::C14N' => ['__benevolent<string|false>', 'exclusive='=>'bool', 'with_comments='=>'bool', 'xpath='=>'array|null', 'ns_prefixes='=>'array|null'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://www.php.net/manual/fr/domnode.c14n.php and https://www.php.net/manual/fr/domnode.c14nfile.php it also return false.

I used benevolent union to be consistent with other methods

'DOMNode::C14NFile' => ['__benevolent<int|false>', 'uri='=>'string', 'exclusive='=>'bool', 'with_comments='=>'bool', 'xpath='=>'array|null', 'ns_prefixes='=>'array|null'],
'DOMNode::cloneNode' => ['__benevolent<DOMNode|false>', 'deep='=>'bool'],
'DOMNode::getLineNo' => ['int'],
'DOMNode::getNodePath' => ['?string'],
Expand Down
Loading