Try reportNestedTooWideType again #4427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Contributor
|
@ondrejmirtes do you have a reference in which PR we talked about the mentioned problems. I can't remember/find it in which context I tested this before. |
Member
Author
|
@staabm I don't think so, just this one phpstan/phpstan#13482 but it's not about a nested type. |
Contributor
|
checked 5 different projects and could not find a false positive |
Collaborator
|
This pull request has been marked as ready for review. |
Member
Author
|
Alright, let's try this again. I'm a little bit worried about this being too annoying still, even if there aren't false positives. |
Contributor
|
just found a false positive in phpstan/phpstan#13676 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.