Skip to content

Reduce file-parsing in ResultCacheManager #4491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

Reduce file-parsing in ResultCacheManager #4491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/Analyser/ResultCache/ResultCacheManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@
use PHPStan\Internal\ArrayHelper;
use PHPStan\Internal\ComposerHelper;
use PHPStan\PhpDoc\StubFilesProvider;
use PHPStan\Reflection\ReflectionProvider;
use PHPStan\ShouldNotHappenException;
use ReflectionClass;
use ReflectionException;
use Throwable;
use function array_diff;
use function array_fill_keys;
Expand Down Expand Up @@ -82,7 +83,6 @@ public function __construct(
private ExportedNodeFetcher $exportedNodeFetcher,
#[AutowiredParameter(ref: '@fileFinderScan')]
private FileFinder $scanFileFinder,
private ReflectionProvider $reflectionProvider,
private StubFilesProvider $stubFilesProvider,
private FileHelper $fileHelper,
#[AutowiredParameter(ref: '%resultCachePath%')]
Expand Down Expand Up @@ -936,13 +936,15 @@ private function getProjectExtensionFiles(?array $projectConfig, array $dependen

$classes = ProjectConfigHelper::getServiceClassNames($projectConfig);
foreach ($classes as $class) {
if (!$this->reflectionProvider->hasClass($class)) {
try {
// does not use static reflection to reduce file-parsing
$classReflection = new ReflectionClass($class); /** @phpstan-ignore argument.type */
} catch (ReflectionException) {
continue;
}

$classReflection = $this->reflectionProvider->getClass($class);
$fileName = $classReflection->getFileName();
if ($fileName === null) {
if ($fileName === false) {
continue;
}

Expand Down
Loading