Skip to content

string cast might throw exception #4555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
canvural wants to merge 2 commits into
base: 2.1.x
Choose a base branch
from
Open

string cast might throw exception #4555

canvural wants to merge 2 commits into from
+61 −0

Conversation

@canvural
Copy link
Contributor

@canvural canvural commented Nov 14, 2025

staabm
staabm reviewed Nov 14, 2025
View reviewed changes
@canvural canvural marked this pull request as ready for review November 14, 2025 16:39
@phpstan-bot
Copy link
Collaborator

phpstan-bot commented Nov 14, 2025

This pull request has been marked as ready for review.

@VincentLanglet
Copy link
Contributor

VincentLanglet commented Nov 15, 2025

Does it also solve phpstan/phpstan#5952 ?
You could add a test for this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes left review comments

+2 more reviewers

@staabm staabm staabm left review comments

@VincentLanglet VincentLanglet VincentLanglet left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PHPStan assumes string conversions cannot throw exceptions

5 participants

@canvural @phpstan-bot @VincentLanglet @ondrejmirtes @staabm