FileTypeMapper: Don't deep traverse method/function/hook bodies #4730
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
this PR doesn't work as is, since I did not find yet a way how we can cheaply identify whether a file contains inline classes/functions. any idea whether/how this can be checked? |
Member
|
Can we actually skip it? I think we still need to find all inline But there's a lot of time spent in FileTypeMapper, maybe there are ways to optimize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case we would know that a certain file does not contain any inline functions/class-definitions, we could skip deep traverse method/function/hook bodies.
testing suggests, this would save us 10 MB of memory when running
php bin/phpstan analyse src/Analyser/ src/Rules/ -v --debug